does someone who knows react/redux and has some familiarity with the mastodon frontend feel like giving me some feedback on the code in this PR? https://github.com/tootsuite/mastodon/pull/7801

@chr yea gimme a sec i'll take a look ;)

@kibi thanks kibi!!

@chr made comments~

@chr i don't know the specifics of what you're doing well enough to know if this will be helpful advice but:

you might want to give the column a react state that is used iff the redux state is absent (aka it is not a pinned column)

a couple other components use this pattern: use the prop if present, use a local react state if not

@chr one thing that's a little weird/different about this approach though would be that the state wouldn't be kept across closing/reopening the column, which (i think??) is different from how it is stored for things like "show reblogs" (which is preserved across closing/opening the home timeline i think??) so maybe ignore this advice and copy that method of storing things ^^;;

@kibi that was my first thought, but "show reblogs" works by setting a filter on the status list (entirely clientside), while this requires actually subscribing to a different timeline (public:media or community:media) and replacing the status list

which is fine, they can do that just dandy when in a column where i can update the onlyMedia property, but unlike show reblogs / show replies, onlyMedia isn't read out of the redux state it seems like

@chr you'll have to add it probably; what i remember is this:

column settings are stored by type, regardless of whether the column is pinned, eg "public" or "hashtag:#{tag}" (i don't remember the strings exactly). if you somehow managed to open two columns of the same type at once, they'd share settings. (some people don't like this behavior, but.)

so what you'll need to do is add a new prop to THAT object, and do everything based on that

@chr i think things are set up fairly automagically to where if you just dispatch/map from the new prop name, everything else will fall into place. and then when it comes to which timeline to subscribe to, you'll need to (a) use the prop rather than the URL to determine, and (b) set it up to unsubscribe/resubscribe to the correct timeline on prop change